Feat: add gpt 5 models and verbosity param #4086
Conversation
|
@sobychacko @markpollack updating the latest changes from 1a3ed95 Gpt-5 models: https://platform.openai.com/docs/models |
apappascs
changed the title
| * <p> | ||
| * Note: GPT-5 models require temperature=1.0 (default value). Custom temperature | ||
| * values are not supported and will cause errors. |
There was a problem hiding this comment.
Is this not the case anymore? In that case, we need to update the docs changed in this commit: https://github.com/spring-projects/spring-ai/pull/4068/files
There was a problem hiding this comment.
thank youi for pointing out this one @sobychacko . it is the case for all gpt 5 models but not the gpt-5-chat model . https://community.openai.com/t/temperature-in-gpt-5-models/1337133/25
I have update documentation and added tests as well
There was a problem hiding this comment.
Does it mean that the gpt 5 models default to a value of temperature 1.0? If so, I think we should make that clear in the docs or javadocs. From what I hear from you, the GPT 5 models completely ignore temperature and internally default to a value of 1.0. Is that correct?
There was a problem hiding this comment.
Yes, that is correct. Azure mentions also more params that are not supported, but I am am not sure if that info has to be on spring ai documentation as it is not a limitation of the framework but from the LLM model itself.
The following are currently unsupported with reasoning models:
temperature, top_p, presence_penalty, frequency_penalty, logprobs, top_logprobs, logit_bias, max_tokens
- update gpt-5 tests - add verbosity parameter - udpate documentation and add tests Signed-off-by: Alexandros Pappas <[email protected]>
apappascs
force-pushed
the
feat/gpt-5-models
branch
from
37a5830 to
826175b
Compare
- update gpt-5 tests - add verbosity parameter - udpate documentation and add tests Fixes #4086 Signed-off-by: Alexandros Pappas <[email protected]> (cherry picked from commit fef454b)
Add gpt-5 models and update their tests